remove old naming scheme and use DD where appropriate - #43
Merged
Conversation
NGA-TRAN
approved these changes
Jul 11, 2025
| - name: dd_WORKER_DEPLOYMENT_PORT | ||
| value: "20201" | ||
| - name: DFRAY_WORKER_DEPLOYMENT_NAMESPACE | ||
| - name: dd_WORKER_DEPLOYMENT_NAMESPACE |
Collaborator
There was a problem hiding this comment.
So you mean we should keep dd lowercase to stay consistent?
Collaborator
Author
There was a problem hiding this comment.
Oh, let me fix that.
This was referenced Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing any of the old naming schemes.
TODOUpdate the readme as well, we should write it by hand, so it can be saved for a subsequent PR when we convert this to have an entry via a lib as well as an arrow flight sql proxyEdit: Now that we no longer have Ray, we don't have collisions with the concept of Worker, so DDProcessorService has been renamed DDWorkerService.